Wait for the job to be removed #64439
Conversation
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
added
the
size/S
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
approved
k8s-github-robot
added
the
do-not-merge/cherry-pick-not-approved
| By("verifying the job " + jobName + " was deleted") | ||
| _, err := c.BatchV1().Jobs(ns).Get(jobName, metav1.GetOptions{}) | ||
| _, err = c.BatchV1().Jobs(ns).Get(jobName, metav1.GetOptions{}) |
There was a problem hiding this comment.
So we can use _, err = framework.WaitForJobGone(c, ns, jobName, 0) here, right?
There was a problem hiding this comment.
Yeah, I guess we could, but I've just backported what we have in master right now.
|
/retest |
MaciekPytel
added
cherry-pick-approved
|
[MILESTONENOTIFIER] Milestone Pull Request Labels Incomplete @MaciekPytel @deads2k @soltysh Action required: This pull request requires label changes. If the required changes are not made within 3 days, the pull request will be moved out of the v1.10 milestone. kind: Must specify exactly one of |
|
This is the equivalent of the e2es we have in master that do the "wait for GC" now, right? /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yup |
|
/retest |
|
/test pull-kubernetes-e2e-kops-aws |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
What this PR does / why we need it:
In master we've dropped reapers (#63979) which means the old client does not wait long enough for the resource to be gone (since it's being removed on the server along with its dependents). To fix our e2e (failure here) we need to backport parts of the aforementioned PR which is updating tests to wait for the resource to be removed.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #64362
/assign @MaciekPytel
/assign @deads2k
Release note: